Make got an external dependency for the Node build target#15
Closed
joshlory wants to merge 1 commit intoscratchfoundation:developfrom
Closed
Make got an external dependency for the Node build target#15joshlory wants to merge 1 commit intoscratchfoundation:developfrom
got an external dependency for the Node build target#15joshlory wants to merge 1 commit intoscratchfoundation:developfrom
Conversation
Author
|
(I think this issue goes away if |
Contributor
Contributor
|
+1 to moving to |
Author
|
Closing this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Issue #14.
Proposed Changes
Move
gotfrom a "devDependency" to a "dependency". Mark it as external for the Node.js webpack build.Reason for Changes
Making
gotan explicit dependency lets the consuming project control whethergotis built for a node or web target.Test Coverage
I struggled a bit getting solid test coverage of this, or even a standalone repro case. It only happens when for
import Storage from 'scratch-storage'is used in a client-side project.I wrote a sample test case to verify gzipped assets can be loaded, but
npm testruns via Node.js it doesn't repro the issue 😕. Happy to add appropriate coverage if you know of a better approach!